[Bugfix #535] Fix: af open cross-workspace file resolution#547
Merged
waleedkadous merged 1 commit intomainfrom Feb 23, 2026
Merged
Conversation
waleedkadous
force-pushed
the
builder/bugfix-535-af-open-does-not-reliably-work
branch
from
7df1027 to
fc2f8c6
Compare
…ace file opens Root cause: open.ts derived workspace from the file's location (findWorkspaceRoot(dirname(filePath))). When running af open from workspace A targeting a file in workspace B, the file opened in B's viewer instead of A's. Fix: Prefer CWD-based workspace detection so files open in the user's active workspace. Fall back to file-based detection when CWD isn't in a recognizable workspace (e.g., running from /tmp).
waleedkadous
force-pushed
the
builder/bugfix-535-af-open-does-not-reliably-work
branch
from
fc2f8c6 to
61d8b10
Compare
Contributor
Author
waleedkadous
deleted the
builder/bugfix-535-af-open-does-not-reliably-work
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
af openderived workspace from the file's location instead of the user's CWD. When opening a file from workspace A that physically resides in workspace B, it opened in B's annotation viewer instead of A's.Fixes #535
Root Cause
open.tsusedfindWorkspaceRoot(dirname(filePath))to determine which workspace to target. This meant the workspace was always derived from where the file lives, not where the user is working. For cross-workspace file opens (e.g., opening a codev source file from the marketmaker workspace), the file tab was created in the wrong workspace's viewer.Fix
Prefer CWD-based workspace detection (
findWorkspaceRoot(process.cwd())), which correctly identifies the user's active workspace. Fall back to file-based detection only when CWD isn't in a recognizable workspace (nocodev/or.git/directory).Test Plan
bugfix-535-af-open-cross-workspace.test.ts)